fix last order column only when DML #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we do not know columnInformation values dictionary key is always null so overwrite value Object. Thus always values dictionary has last order column object value To avoid user confusion, it is marked and displayed as UNKNOWN_COL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #510
Description
Over pymyrepli 1.0 version
We got column Information from optional metadata
BUT If Mysql 5.7 Users use over 1.0 version They do not get Column Information.
Mysql 5.7 version does not have binlog_row_metadata variable. so we support 0.45.1 version for mysql 5.7 version
Nevertheless If Mysql 5.7 version use over 1.0 Version, users found only last order column Values.
When we do not know column Information values dictionary key is always null, So overwrite value Object.
Solution
To avoid user confusion, it is marked and displayed as UNKNOWN_COL.